Make the generated code compatible with nodejs natives modules

Cargo.lock

@@ -561,7 +561,7 @@ checksum = "49f1f14873335454500d59611f1cf4a4b0f786f9ac11f4312a78e4cf2566695b"
 
 [[package]]
 name = "jrpc-cli"
-version = "0.1.1"
+version = "0.1.5"
 dependencies = [
  "anyhow",
  "clap",
@@ -607,7 +607,7 @@ checksum = "561d97a539a36e26a9a5fad1ea11a3039a67714694aaa379433e580854bc3dc5"
 
 [[package]]
 name = "libjrpc"
-version = "0.1.0"
+version = "0.1.5"
 dependencies = [
  "anyhow",
  "lazy_static",

Cargo.toml

@@ -1,7 +1,7 @@
 [package]
 edition = "2021"
 name = "jrpc-cli"
-version = "0.1.1"
+version = "0.1.5"
 
 [workspace]
 resolver = "2"
@@ -12,6 +12,7 @@ anyhow = "1"
 clap = { version = "4", features = ["derive"] }
 libjrpc = { path = "libjrpc" }
 log = "0.4"
-simple_logger = { version = "5.0.0", features = ["threads"] }
+simple_logger = { version = "5", features = ["threads"] }
+
 [dev-dependencies]
 walkdir = "2"

libjrpc/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "libjrpc"
-version = "0.1.0"
+version = "0.1.5"
 edition = "2021"
 
 [features]
@@ -8,9 +8,9 @@ default = ["http"]
 http = ["dep:reqwest", "dep:url"]
 
 [dependencies]
-anyhow = "1.0.89"
-lazy_static = "1.5.0"
-log = "0.4.22"
-regex = "1.10.6"
-reqwest = { version = "0.12.7", optional = true, features = ["blocking"] }
-url = { version = "2.5.2", optional = true }
+anyhow = "1"
+lazy_static = "1"
+log = "0.4"
+regex = "1"
+reqwest = { version = "0.12", optional = true, features = ["blocking"] }
+url = { version = "2", optional = true }

libjrpc/src/compile.rs

@@ -88,6 +88,7 @@ impl CompileContext {
     pub fn write_file(&self, filename: &str, content: &str) -> Result<()> {
         let res_path = self.output_folder.clone().join(filename);
         let res_dir = res_path.parent().context("Path has no parent!")?;
+        log::debug!("Writing to file {:?}", res_path);
         std::fs::create_dir_all(res_dir)?;
         std::fs::write(res_path, content)?;
         Ok(())

libjrpc/src/targets/csharp.rs

@@ -0,0 +1,404 @@
+use anyhow::Result;
+use log::warn;
+use std::collections::{BTreeMap, BTreeSet};
+use std::fmt::format;
+
+use crate::compile::{Compile, CompileContext, FileGenerator};
+use crate::ir::{BaseType, EnumDefinition, ServiceDefinition, Step, Type, TypeDefinition};
+use crate::shared::Keywords;
+use crate::IR;
+
+pub struct CSharpCompiler {
+    namespace: String,
+}
+
+static CSHARP_KEYWORDS: [&'static str; 5] = ["event", "internal", "public", "private", "static"];
+
+impl CSharpCompiler {
+    fn type_to_csharp(typ: &BaseType) -> String {
+        match typ {
+            BaseType::String => "string".to_string(),
+            BaseType::Int => "long".to_string(),
+            BaseType::Float => "double".to_string(),
+            BaseType::Bool => "bool".to_string(),
+            BaseType::Bytes => todo!("Bytes are not implemented for C#"),
+            BaseType::Void => "void".to_string(),
+            BaseType::Custom(name) => name.clone(),
+        }
+    }
+
+    fn type_to_csharp_ext(typ: &Type) -> String {
+        let mut result = Self::type_to_csharp(&typ.0);
+
+        let (optional, array, map) = typ.1.get_flags();
+
+        if array {
+            result = format!("IList<{}>", result);
+        }
+        if let Some(map) = &map {
+            result = format!("Dictionary<{}, {}>", Self::type_to_csharp(&map), result);
+        }
+        if optional {
+            result = format!("{}?", result);
+        }
+        result
+    }
+
+    fn fix_keyword_name(name: &str) -> String {
+        if CSHARP_KEYWORDS.contains(&name) {
+            format!("{}_", name)
+        } else {
+            name.to_string()
+        }
+    }
+
+    fn generate_service_server(
+        &mut self,
+        ctx: &mut CompileContext,
+        definition: &ServiceDefinition,
+    ) -> anyhow::Result<()> {
+        let mut f = FileGenerator::new();
+
+        f.a0("using System;");
+        f.a0("using System.Text.Json;");
+        f.a0("using System.Text.Json.Serialization;");
+        f.a0("using System.Text.Json.Nodes;");
+        f.a0("using System.Threading.Tasks;");
+        f.a0("using System.Collections.Generic;");
+
+        f.a0("");
+        f.a0(format!("namespace {};", self.namespace));
+        f.a0("");
+
+        f.a0(format!(
+            "public abstract class {}Server<TContext> : JRpcService<TContext> {{",
+            definition.name
+        ));
+        f.a1("public override string Name {");
+        f.a2("get {");
+        f.a3(format!("return \"{}\";", definition.name));
+        f.a2("}");
+        f.a1("}");
+
+        f.a1(format!("public {}Server() {{", definition.name));
+        for method in &definition.methods {
+            f.a2(format!("this.RegisterFunction(\"{}\");", method.name));
+        }
+        f.a1("}");
+        f.a0("");
+
+        for fnc in &definition.methods {
+            let mut args = fnc
+                .inputs
+                .iter()
+                .map(|inp| {
+                    format!(
+                        "{} {}",
+                        Self::type_to_csharp_ext(&inp.typ),
+                        Self::fix_keyword_name(&inp.name)
+                    )
+                })
+                .collect::<Vec<String>>();
+            args.push("TContext ctx".to_string());
+            let args = args.join(",");
+
+            if let Some(output) = &fnc.output {
+                if output.typ.0 == BaseType::Void {
+                    f.a1(format!("public abstract Task {}({});", fnc.name, args));
+                } else {
+                    f.a1(format!(
+                        "public abstract Task<{}> {}({});",
+                        Self::type_to_csharp_ext(&output.typ),
+                        fnc.name,
+                        args
+                    ));
+                }
+            } else {
+                f.a1(format!("public abstract void {}({});", fnc.name, args));
+            }
+        }
+
+        f.a0("");
+        f.a1("public async override Task<JsonNode?> HandleRequest(string func, JsonNode param, TContext context) {");
+        f.a2("switch(func) {");
+        for fnc in &definition.methods {
+            f.a3(format!("case \"{}\": {{", fnc.name));
+            f.a4("if(param is JsonObject) {");
+            let args_array = fnc
+                .inputs
+                .iter()
+                .map(|inp| format!("param[\"{}\"]", inp.name))
+                .collect::<Vec<String>>();
+            f.a5(format!(
+                "var ja = new JsonArray({});",
+                args_array.join(", ")
+            ));
+            f.a5("param = ja;");
+            f.a4("}");
+
+            let pref = if let Some(output) = &fnc.output {
+                if output.typ.0 == BaseType::Void {
+                    "await"
+                } else {
+                    "var result = await"
+                }
+            } else {
+                ""
+            };
+
+            let mut args_array = fnc
+                .inputs
+                .iter()
+                .map(|inp| {
+                    format!(
+                        "param[\"{}\"]!.Deserialize<{}>()",
+                        inp.name,
+                        Self::type_to_csharp_ext(&inp.typ)
+                    )
+                })
+                .collect::<Vec<String>>();
+            args_array.push("context".to_string());
+            let args_array = args_array.join(", ");
+            f.a4(format!("{} this.{}({});", pref, fnc.name, args_array));
+            if let Some(output) = &fnc.output {
+                if output.typ.0 == BaseType::Void {
+                    f.a4("return null;");
+                } else {
+                    f.a4("return JsonSerializer.SerializeToNode(result);");
+                }
+            } else {
+                f.a4("return null;");
+            };
+            f.a3("}");
+        }
+        f.a3("default: {");
+        f.a4("throw new Exception(\"Invalid Method!\");");
+        f.a3("}");
+        f.a2("}");
+        f.a1("}");
+
+        f.a0("}");
+
+        ctx.write_file(&format!("{}Server.cs", &definition.name), &f.into_content())?;
+
+        Ok(())
+    }
+
+    fn generate_service_client(
+        &mut self,
+        ctx: &mut CompileContext,
+        definition: &ServiceDefinition,
+    ) -> anyhow::Result<()> {
+        let mut f = FileGenerator::new();
+
+        f.a0("using System;");
+        f.a0("using System.Text.Json;");
+        f.a0("using System.Text.Json.Serialization;");
+        f.a0("using System.Text.Json.Nodes;");
+        f.a0("using System.Threading.Tasks;");
+        f.a0("using System.Collections.Generic;");
+
+        f.a0("");
+        f.a0(format!("namespace {};", self.namespace));
+        f.a0("");
+
+        f.a0(format!("public class {}Client {{", definition.name));
+        f.a1("private JRpcClient Client;");
+        f.a1(format!(
+            "public {}Client(JRpcClient client) {{",
+            definition.name
+        ));
+        f.a2("this.Client = client;");
+        f.a1("}");
+        f.a0("");
+        for fnc in &definition.methods {
+            let args = fnc
+                .inputs
+                .iter()
+                .map(|inp| {
+                    format!(
+                        "{} {}",
+                        Self::type_to_csharp_ext(&inp.typ),
+                        Self::fix_keyword_name(&inp.name)
+                    )
+                })
+                .collect::<Vec<String>>()
+                .join(", ");
+
+            let args_code = format!(
+                "var param = new JsonArray({});",
+                fnc.inputs
+                    .iter()
+                    .map(|inp| {
+                        format!(
+                            "JsonSerializer.SerializeToNode({})",
+                            Self::fix_keyword_name(&inp.name)
+                        )
+                    })
+                    .collect::<Vec<String>>()
+                    .join(", ")
+            );
+
+            if let Some(output) = &fnc.output {
+                if output.typ.0 == BaseType::Void {
+                    f.a1(format!("public async Task {}({}) {{", fnc.name, args));
+                    f.a2(args_code);
+                    f.a2(format!(
+                        "await Client.SendRequestRaw(\"{}.{}\", param);",
+                        definition.name, fnc.name,
+                    ));
+                    f.a1("}");
+                } else {
+                    f.a1(format!(
+                        "public async Task<{}> {}({}) {{",
+                        Self::type_to_csharp_ext(&output.typ),
+                        fnc.name,
+                        args
+                    ));
+                    f.a2(args_code);
+                    f.a2(format!(
+                        "return await Client.SendRequest<{}>(\"{}.{}\", param);",
+                        Self::type_to_csharp_ext(&output.typ),
+                        definition.name,
+                        fnc.name,
+                    ));
+                    f.a1("}");
+                }
+            } else {
+                f.a1(format!("public void {}({}) {{", fnc.name, args));
+                f.a2(args_code);
+                f.a2(format!(
+                    "Client.SendNotification(\"{}.{}\", param);",
+                    definition.name, fnc.name,
+                ));
+                f.a1("}");
+            }
+        }
+
+        f.a0("}");
+
+        ctx.write_file(&format!("{}Client.cs", &definition.name), &f.into_content())?;
+
+        Ok(())
+    }
+}
+
+impl Compile for CSharpCompiler {
+    fn new(options: &BTreeMap<String, String>) -> anyhow::Result<Self> {
+        let namespace = if let Some(namespace) = options.get("csharp_namespace") {
+            namespace.to_string()
+        } else {
+            "JRPC".to_string()
+        };
+
+        if let Some(allow_bytes) = options.get("allow_bytes") {
+            if allow_bytes == "true" {
+                anyhow::bail!("allow_bytes option is not supported for csharp compiler");
+            }
+        }
+
+        Ok(CSharpCompiler { namespace })
+    }
+
+    fn name(&self) -> String {
+        "csharp".to_string()
+    }
+
+    fn start(&mut self, ctx: &mut CompileContext) -> anyhow::Result<()> {
+        let fix_ns = |input: &str| input.replace("__NAMESPACE__", &self.namespace);
+
+        ctx.write_file(
+            &format!("{}.csproj", self.namespace),
+            &fix_ns(include_str!("../../templates/CSharp/CSharp.csproj")),
+        )?;
+
+        ctx.write_file(
+            "JRpcClient.cs",
+            &fix_ns(include_str!("../../templates/CSharp/JRpcClient.cs")),
+        )?;
+
+        ctx.write_file(
+            "JRpcServer.cs",
+            &fix_ns(include_str!("../../templates/CSharp/JRpcServer.cs")),
+        )?;
+
+        ctx.write_file(
+            "JRpcTransport.cs",
+            &fix_ns(include_str!("../../templates/CSharp/JRpcTransport.cs")),
+        )?;
+
+        Ok(())
+    }
+
+    fn generate_type(
+        &mut self,
+        ctx: &mut CompileContext,
+        definition: &TypeDefinition,
+    ) -> anyhow::Result<()> {
+        let mut f = FileGenerator::new();
+
+        f.a0("using System.Text.Json;");
+        f.a0("using System.Text.Json.Serialization;");
+        f.a0("using System.Collections.Generic;");
+        f.a0("");
+        f.a0(format!("namespace {};", self.namespace));
+        f.a0("");
+        f.a0(format!("public class {} {{", definition.name));
+
+        for field in &definition.fields {
+            f.a1(format!("[JsonPropertyName(\"{}\")]", field.name));
+
+            f.a1(format!(
+                "public {} {} {{ get; set; }}",
+                Self::type_to_csharp_ext(&field.typ),
+                Self::fix_keyword_name(&field.name)
+            ));
+        }
+
+        f.a0("}");
+
+        ctx.write_file(&format!("{}.cs", &definition.name), &f.into_content())?;
+
+        Ok(())
+    }
+
+    fn generate_enum(
+        &mut self,
+        ctx: &mut CompileContext,
+        definition: &EnumDefinition,
+    ) -> anyhow::Result<()> {
+        let mut f = FileGenerator::new();
+
+        f.a0("using System.Text.Json;");
+        f.a0("using System.Text.Json.Serialization;");
+        f.a0("");
+        f.a0(format!("namespace {};", self.namespace));
+        f.a0("");
+
+        f.a0(format!("public enum {} {{", definition.name));
+
+        for variant in &definition.values {
+            f.a1(format!("{} = {},", variant.name, variant.value));
+        }
+
+        f.a0("}");
+
+        ctx.write_file(&format!("{}.cs", &definition.name), &f.into_content())?;
+
+        Ok(())
+    }
+
+    fn generate_service(
+        &mut self,
+        ctx: &mut CompileContext,
+        definition: &ServiceDefinition,
+    ) -> anyhow::Result<()> {
+        self.generate_service_client(ctx, definition)?;
+        self.generate_service_server(ctx, definition)?;
+        Ok(())
+    }
+
+    fn finalize(&mut self, ctx: &mut CompileContext, ir: &IR) -> anyhow::Result<()> {
+        Ok(())
+    }
+}

libjrpc/src/targets/mod.rs

@@ -4,6 +4,7 @@ use std::{
 };
 
 use anyhow::Result;
+use log::debug;
 
 use crate::{
     compile::{Compile, CompileContext},
@@ -11,6 +12,7 @@ use crate::{
     IR,
 };
 
+pub mod csharp;
 pub mod rust;
 pub mod typescript;
 
@@ -50,6 +52,7 @@ pub fn compile<T: Compile>(ir: IR, output: &str) -> Result<()> {
     for step in ir.steps.iter() {
         match step {
             crate::ir::Step::Type(definition) => {
+                debug!("Generating type {}", definition.name);
                 match compiler.generate_type(&mut ctx, &definition) {
                     Ok(_) => (),
                     Err(err) => {
@@ -58,6 +61,7 @@ pub fn compile<T: Compile>(ir: IR, output: &str) -> Result<()> {
                 }
             }
             crate::ir::Step::Enum(definition) => {
+                debug!("Generating enum {}", definition.name);
                 match compiler.generate_enum(&mut ctx, &definition) {
                     Ok(_) => (),
                     Err(err) => {
@@ -66,6 +70,7 @@ pub fn compile<T: Compile>(ir: IR, output: &str) -> Result<()> {
                 }
             }
             crate::ir::Step::Service(definition) => {
+                debug!("Generating service {}", definition.name);
                 match compiler.generate_service(&mut ctx, &definition) {
                     Ok(_) => (),
                     Err(err) => {

libjrpc/src/targets/rust.rs

@@ -463,7 +463,17 @@ impl Compile for RustCompiler {
 
         self.add_dependencies(&mut f, &definition.depends)?;
 
-        f.a0("#[derive(Clone, Debug, Serialize, Deserialize)]");
+        let only_optional = definition
+            .fields
+            .iter()
+            .find(|f| !f.typ.is_optional())
+            .is_none();
+
+        let derive_default_none = if only_optional { ", Default" } else { "" };
+        f.a0(format!(
+            "#[derive(Clone, Debug, Serialize, Deserialize{})]",
+            derive_default_none
+        ));
         f.a0(format!("pub struct {} {{", definition.name));
         for field in definition.fields.iter() {
             f.a(1, "#[allow(non_snake_case)]");

libjrpc/src/targets/typescript.rs

@@ -435,12 +435,8 @@ import {{ VerificationError }} from \"./ts_base{esm}\";
 }
 
 impl<F: Flavour> Compile for TypeScriptCompiler<F> {
-    fn new(options: &BTreeMap<String, String>) -> Result<Self> {
-        let flavour = options
-            .get("flavour")
-            .cloned()
-            .unwrap_or_else(|| "node".to_string());
-        info!("TypeScript target initialized with flavour: {}", flavour);
+    fn new(_options: &BTreeMap<String, String>) -> Result<Self> {
+        info!("TypeScript target initialized with flavour: {}", F::name());
         Ok(TypeScriptCompiler {
             flavour: std::marker::PhantomData,
         })

libjrpc/templates/TypeScript/ts_service_client.ts

@@ -63,7 +63,10 @@ export class ServiceProvider {
             let resListener = this.requests.get(msg.id);
             if (!resListener) return; // Ignore wrong responses
             if (msg.error) {
-        if (msg.error.data && msg.error.data.$ == "verification_error") {
+                if (
+                    msg.error.data &&
+                    msg.error.data.$ == "verification_error"
+                ) {
                     resListener.err(
                         new VerificationError(
                             msg.error.data.type,
@@ -112,14 +115,26 @@ export const getRandomBytes = (
               return function (n: number) {
                   var a = new Uint8Array(n);
                   for (var i = 0; i < n; i += QUOTA) {
-            crypto.getRandomValues(a.subarray(i, i + Math.min(n - i, QUOTA)));
+                      crypto.getRandomValues(
+                          a.subarray(i, i + Math.min(n - i, QUOTA)),
+                      );
                   }
                   return a;
               };
           }
         : function () {
               // Node
+              if (typeof require !== "undefined") {
                   return require("crypto").randomBytes;
+              } else {
+                  return (n: number) => {
+                      let a = new Uint8Array(n);
+                      for (let i = 0; i < n; i++) {
+                          a[i] = Math.floor(Math.random() * 256);
+                      }
+                      return a;
+                  };
+              }
           }
 )() as (cnt: number) => Uint8Array;
 

src/main.rs

@@ -2,8 +2,9 @@ use anyhow::Result;
 use clap::{Parser, Subcommand};
 use libjrpc::{
     targets::{
+        csharp::CSharpCompiler,
         rust::RustCompiler,
-        typescript::{Node, TypeScriptCompiler},
+        typescript::{Node, TypeScriptCompiler, ESM},
     },
     FileProcessor,
 };
@@ -65,8 +66,9 @@ pub fn main() -> Result<()> {
                         libjrpc::targets::compile::<TypeScriptCompiler<Node>>(ir, output_dir)?
                     }
                     "ts-esm" => {
-                        libjrpc::targets::compile::<TypeScriptCompiler<Node>>(ir, output_dir)?
+                        libjrpc::targets::compile::<TypeScriptCompiler<ESM>>(ir, output_dir)?
                     }
+                    "csharp" => libjrpc::targets::compile::<CSharpCompiler>(ir, output_dir)?,
                     _ => {
                         println!("Unsupported target: {}", output_target);
                     }
@@ -83,6 +85,7 @@ pub fn main() -> Result<()> {
             println!("rust");
             println!("ts-node");
             println!("ts-esm");
+            println!("csharp")
         }
     }
 

src/test.rs

@@ -6,12 +6,12 @@ use std::{
 
 #[test]
 fn compare_tools() {
-    let targets = vec!["rust"];
+    let targets = vec!["js-esm"];
     for target in targets {
         std::fs::remove_dir_all("./tests").unwrap();
         std::fs::create_dir_all("./tests").unwrap();
 
-        Command::new("cargo")
+        let result1 = Command::new("cargo")
             .arg("run")
             .arg("--")
             .arg("compile")
@@ -26,7 +26,11 @@ fn compare_tools() {
             .wait()
             .unwrap();
 
-        Command::new("node")
+        if !result1.success() {
+            panic!("Failed to generate Rust code");
+        }
+
+        let result2 = Command::new("node")
             .arg("JsonRPC/lib/jrpc.js")
             .arg("compile")
             .arg("--verbose")
@@ -40,6 +44,10 @@ fn compare_tools() {
             .wait()
             .unwrap();
 
+        if !result2.success() {
+            panic!("Failed to generate JavaScript code");
+        }
+
         let rust_files = walkdir::WalkDir::new("tests/rust")
             .into_iter()
             .map(|e| e.unwrap())