hibas123/JsonRPC
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove request from requests dict after it was handled. This was a memory leak!

Browse Source
This commit is contained in:
Fabian Stamm
2024-09-27 08:51:55 +02:00
parent bc19a315da
commit 036897ecab
2 changed files with 27 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
templates/CSharp/JRpcClient.cs
View File

@ -89,27 +89,41 @@ public class JRpcClient
var task = new TaskCompletionSource<JsonNode?>();
this.Requests.Add(id, task);
_ = Task.Run(async () =>
{
await this.Transport.Write(request.ToJsonString());
});
if (this.Timeout.HasValue)
try
{
if (await Task.WhenAny(task.Task, Task.Delay(this.Timeout.Value)) == task.Task)
_ = Task.Run(async () =>
{
return await task.Task;
try
{
await this.Transport.Write(request.ToJsonString());
}
catch (Exception e)
{
task.SetException(e);
}
});
if (this.Timeout.HasValue)
{
if (await Task.WhenAny(task.Task, Task.Delay(this.Timeout.Value)) == task.Task)
{
return await task.Task;
}
else
{
throw new JRpcTimeoutException();
}
}
else
{
this.Requests.Remove(id);
throw new JRpcTimeoutException();
return await task.Task;
}
}
else
finally
{
return await task.Task;
this.Requests.Remove(id);
}
}