hibas123/JsonRPC
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove request from requests dict after it was handled. This was a memory leak!

Browse Source
This commit is contained in:
Fabian Stamm 2024-09-27 08:51:55 +02:00
parent bc19a315da
commit 036897ecab
2 changed files with 27 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
package.json
View File

@ -1,6 +1,6 @@
{ {
"name": "@hibas123/jrpcgen", "name": "@hibas123/jrpcgen",
"version": "1.2.19", "version": "1.2.20",
"main": "lib/index.js", "main": "lib/index.js",
"license": "MIT", "license": "MIT",
"packageManager": "yarn@3.1.1", "packageManager": "yarn@3.1.1",

16
templates/CSharp/JRpcClient.cs
View File

@ -89,9 +89,19 @@ public class JRpcClient
var task = new TaskCompletionSource<JsonNode?>(); var task = new TaskCompletionSource<JsonNode?>();
this.Requests.Add(id, task); this.Requests.Add(id, task);
try
{
_ = Task.Run(async () => _ = Task.Run(async () =>
{
try
{ {
await this.Transport.Write(request.ToJsonString()); await this.Transport.Write(request.ToJsonString());
}
catch (Exception e)
{
task.SetException(e);
}
}); });
if (this.Timeout.HasValue) if (this.Timeout.HasValue)
@ -102,7 +112,6 @@ public class JRpcClient
} }
else else
{ {
this.Requests.Remove(id);
throw new JRpcTimeoutException(); throw new JRpcTimeoutException();
} }
@ -112,6 +121,11 @@ public class JRpcClient
return await task.Task; return await task.Task;
} }
} }
finally
{
this.Requests.Remove(id);
}
}
public async Task<TResult?> SendRequest<TResult>(string method, JsonArray param) public async Task<TResult?> SendRequest<TResult>(string method, JsonArray param)
{ {